feat: auto-migrate old index metadata #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
approved these changes
Jan 31, 2025
rust/lance/src/index.rs
Outdated
| @@ -68,6 +68,24 @@ use self::append::merge_indices; | |||
| use self::scalar::build_scalar_index; | |||
| use self::vector::{build_vector_index, VectorIndexParams, LANCE_VECTOR_INDEX}; | |||
|
|
|||
| // Whether to auto-migrate a dataset when we encounter corruption. | |||
| fn auto_migrate_corruption() -> bool { | |||
| static MAX_CONN_RESET_RETRIES: OnceLock<bool> = OnceLock::new(); | |||
There was a problem hiding this comment.
Maybe change the variable name?
rust/lance/src/index.rs
Outdated
Comment on lines
74
to
80
| fn str_is_truthy(val: &str) -> bool { | ||
| val.eq_ignore_ascii_case("1") | ||
| | val.eq_ignore_ascii_case("true") | ||
| | val.eq_ignore_ascii_case("on") | ||
| | val.eq_ignore_ascii_case("yes") | ||
| | val.eq_ignore_ascii_case("y") | ||
| } |
There was a problem hiding this comment.
Put in a util crate somewhere?
| let mut ds = ds.clone(); | ||
| log::warn!( | ||
| "Detecting out-dated fragment metadata, migrating dataset. \ | ||
| To disable migration, set LANCE_AUTO_MIGRATION=false" |
There was a problem hiding this comment.
It's probably fine but this warning is a little too late 😆 . I guess users can always restore.
There was a problem hiding this comment.
Well this is for if they hit it in a production system. Hopefully they catch it on the first table it hits.
wjones127
force-pushed
the
feat/auto-migration
branch
from
e208df6 to
320d101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3377. That PR made
index_statistics()error by default. This ended up being a footgun for some users who rely heavily on that method. So instead of forcing the user to do the migration themself, we do it for them. It can be disabled using an environment variable.