follow up community #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: carlory <[email protected]>
Ensure consistency across resource managers and update ErrorS(nil, ...) to InfoS. Similar changes have been proposed in CPU Manager and Memory Manager. Signed-off-by: Swati Sehgal <[email protected]>
Signed-off-by: Swati Sehgal <[email protected]>
Move some exec helper functions from framework/volume to framework/pod
Self-nominating ffromani as approver for sig-node container and resource managers
testing: Fix pod delete timeout failures after InPlacePodVerticalScaling Graduate to Beta commit
Kubelet server handler cleanup
Nominate macsko to SIG Scheduling approvers
The default handler now uses contextual logging. Instead of
warnings.go:106] warning 1
it now logs the caller of client-go and uses structured, contextual
logging
main.go:100] "Warning" message="warning 1"
Users of client-go have the choice whether the handler that they provide uses
the traditional API (no API break!) or contextual logging.
The BackoffManager interface sleeps without considering the caller's context, i.e. cancellation is not supported. This alone is reason enough to deprecate it and to replace it with an interface that supports a context parameter. The other reason is that contextual logging needs that parameter.
The remaining calls can be converted without API changes.
Storing a context and making sure that it never gets canceled also has overhead. We might as well just do the klog.FromContext when constructing the Result and store the logger for later use.
…#129658) * adding support for providing version for functions in kube_codegen.sh * addressed review comments * addressed review comments
Compiling a CEL expression used to do the cost estimation, whether the caller needed the result or not. Now callers can skip it. The scheduler does that, through the CEL cache. The main advantage is that failures in the estimator (like panics) are limited to the apiserver. Performance in the scheduler is not expected to benefit much because compilation results are cached.
kubeadm: fix a wrong log message
Fix dual stack tests after moving the e2e test to use Endpoint Slices
tests: include stdout of failed commands in JUnit
client-go/rest: finish context support
KEP-1880 Multiple Service CIDRs: Graduate to GA
Signed-off-by: Davanum Srinivas <[email protected]>
…jose/go-jose.v2 Switch to gopkg.in/go-jose/go-jose.v2 @ v2.6.3 and github.com/coreos/go-oidc @ v2.3.0
Revert "tests: include stdout of failed commands in JUnit"
…ith the number of initial nodes.
feature: Make Unschedulable scheduler performance test parametrized with the number of initial nodes.
Signed-off-by: Swati Sehgal <[email protected]>
We have reasonable amount of logs when things go wrong. While debugging, it can be useful to have logs to indicate that things have gone as expected especially when it comes to important events like successful startup of memory manager and successful allocation of resources. Signed-off-by: Swati Sehgal <[email protected]>
Signed-off-by: Swati Sehgal <[email protected]>
Ensure that if possible, we provide sufficient metadata inclusing pod name and UID to allow filtering by pod name or its UID. Signed-off-by: Swati Sehgal <[email protected]>
Signed-off-by: Swati Sehgal <[email protected]>
Signed-off-by: Swati Sehgal <[email protected]>
We have reasonable amount of logs when things go wrong. While debugging, it can be useful to have logs to indicate that things have gone as expected. Signed-off-by: Swati Sehgal <[email protected]>
Signed-off-by: Swati Sehgal <[email protected]>
Throughout the devicemanager codebase the named argument to represent resource for logging pupose is `resourceName` as opposed to `resource`. The latter can only be seen in topology_hints.go files. To ensure consistency with the rest of the codebase and also because we want to adhere to the recommendations in the Kubernetes documentation about named arguments: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md#name-arguments we update the key from `resource` to `resourceName`. Signed-off-by: Swati Sehgal <[email protected]>
Ensure that the log messages adhere to the message style guildelines as captured [here](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md#message-style-guidelines). Signed-off-by: Swati Sehgal <[email protected]>
…ol/pv to csi failure Signed-off-by: Anish Ramasekar <[email protected]>
Ensure that the log messages adhere to the message style guildelines as captured [here](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md#message-style-guidelines). Signed-off-by: Swati Sehgal <[email protected]>
…e_vol/pv to csi Signed-off-by: Anish Ramasekar <[email protected]>
… in v1.32 Signed-off-by: Anish Ramasekar <[email protected]>
…in v1.33 Signed-off-by: Anish Ramasekar <[email protected]>
KEP-4330: Refactor compatibility version code
Fix service account node audience restriction for in-tree pv to csi migration
…ntnodeaudiencerestriction_1.33 Enable ServiceAccountNodeAudienceRestriction feature gate by default in v1.33
Add volume modify recovery e2e test
client-go watch: context support
Signed-off-by: Daman Arora <[email protected]>
Signed-off-by: Daman Arora <[email protected]>
Memory Manager logging improvements
CPU Manager logging improvements
Conntrack memory leak fix
Device Manager logging improvements
…gate remove unnecessary comment from feature-gate
…ches Signed-off-by: cpanato <[email protected]>
update publishing rules to use go1.22.10 for some active release branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: