Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lando/lando#2679: Use DROP/CREATE strategy for MySQL DB reset #59

Closed
wants to merge 1 commit into from

Conversation

xurizaemon
Copy link

@xurizaemon xurizaemon commented Nov 2, 2021

In lando/mysql#52 there's a report of Lando failing to wipe existing MySQL DB tables on db-import because it attempts to drop the table as a view first (and MySQL apparently lets you do DROP TABLE IF EXISTS but not DROP VIEW IF EXISTS AND IS ALSO NOT A TABLE).

Existing approach came from lando/lando#2539

Copy link
Member

@reynoldsalec reynoldsalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is non-working; see comment and the test results. Guessing it's something about that DB command based on the errors.


# Drop and recreate database
lando_yellow "Dropping database ...\n"
$SQLSTART -e "DROP DATABASE IF EXISTS ${DATABASE}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about this line is failing (see the test results for the PR or try using the db-export example and running the lando db-import test.sql on it).

@netlify
Copy link

netlify bot commented Oct 10, 2022

👷 Deploy request for lando-cli pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 30155c8

@xurizaemon
Copy link
Author

xurizaemon commented Oct 10, 2022

30155c8 does not address the requested changes above, just rebasing to pick up current main.

@reynoldsalec would you please permit the tests to run?

I confess I can't actually see in "Checks" above the failed results from last time, am happy to look at the failed test if you can point me in the right direction!

image of PR header showing "Checks: 0"

I do see some actions trying to run at https://github.com/xurizaemon/cli/actions/runs/3221360605/jobs/5269200430 but I don't think this is the tests we want (it's failing for lack of Docker Hub creds, and I probably don't want to push Lando images there at this point).

@xurizaemon
Copy link
Author

I can now see https://github.com/lando/cli/actions/runs/3221353780/jobs/5269616590 is the failing job

xurizaemon added a commit to xurizaemon/lando-core-next that referenced this pull request Jul 21, 2023
@xurizaemon
Copy link
Author

Closing PR in favour of lando/core-next#40

@xurizaemon xurizaemon closed this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants