-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kcgourishetti/bedrock agents runnable #152
Kcgourishetti/bedrock agents runnable #152
Conversation
15c4238
to
b948c2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcgourishetti
Thanks for submitting these changes. Some minor suggestions before we merge.
if agent_creation_status == 'NOT_PREPARED': | ||
return agent_id | ||
else: | ||
time.sleep(2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a priority, but time.sleep
is blocking, we might want to look into asyncio.sleep
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcgourishetti
Great job on all the changes. We are almost there, some minor comments on aligning the create_job
with the create_agent API, and moving notebooks to samples directory.
bedrock_endpoint_url: str = None, | ||
runtime_endpoint_url: str = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that these 2 can be different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, one is the endpoint for control plane responsible for CRUDL of the agents and one is the runtime responsible for invoke etc. the boto client names for each of these are also different one is bedrock-agent
and other is bedrock-agent-runtime
.
libs/aws/tests/integration_tests/agents/bedrock_agent_langgraph.ipynb
Outdated
Show resolved
Hide resolved
libs/aws/tests/integration_tests/agents/bedrock_agents_roc.ipynb
Outdated
Show resolved
Hide resolved
2e07fbd
to
8477e08
Compare
@kcgourishetti A couple of other observations, not blockers on this PR:
|
|
dd78c7b
to
e2be629
Compare
Description
This PR introduces a new Bedrock Agents Runnable that allows using Bedrock Agents with return of control functions as tools. This completes the work presented in #91.
Usage with AgentExecutor
Usage with LangGraph