-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for function calling with Anthropic models on Bedrock #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bigbernnn
Thanks for working on this change. Can you add integration tests or examples to test this.
Integration tests added for both generate and stream responses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Hi @bigbernnn, @3coins, from my side it seems the tool calling doesn't work for langgraph that relied on |
Hi @3coins @bigbernnn. The current implementation also seems to ignore the |
has any progress been made on this. There doesn't seem to be a standard result that can be parsed to receive the response required. it seems that we would have to rely on a hack using regular expressions |
Hi,
The error is something like:
|
Try the new ChatBedrockConverse model instead (still in beta). It supports tool calling, streaming, structured outputs, etc. Git repo here. |
Workaround for Bedrock support of function calling with Anthropic models. This change adds that
bind_tools
function toChatBedrock
.The workaround is implemented similarly to its equivalent directly using Anthropic prior to the feature currently in beta.