Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax astrapy dependency requirement to accept v 1.* #17

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Relax astrapy dependency requirement to accept v 1.* #17

merged 2 commits into from
Apr 12, 2024

Conversation

hemidactylus
Copy link
Collaborator

No description provided.

cbornet
cbornet reviewed Apr 12, 2024
View reviewed changes
libs/astradb/Makefile Outdated Show resolved Hide resolved
nicoloboschi
nicoloboschi approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I just wonder if we want to add integration tests forcing the installation to 0.7.x to ensure we keep it compatible "for real"

@hemidactylus hemidactylus merged commit 5a1d4d7 into main Apr 12, 2024
13 checks passed
@hemidactylus hemidactylus deleted the SL-astrapy-v1 branch April 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@cbornet cbornet cbornet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hemidactylus @cbornet @nicoloboschi