Use orchestration lib #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxjakob
force-pushed
the
use-orchestration-lib
branch
from
92a4c52
to
dedc31b
Compare
maxjakob
force-pushed
the
use-orchestration-lib
branch
from
b83b811
to
e41dca1
Compare
efriis
reviewed
May 6, 2024
maxjakob
force-pushed
the
use-orchestration-lib
branch
from
63c7756
to
a7beb68
Compare
maxjakob
force-pushed
the
use-orchestration-lib
branch
from
a7beb68
to
46e1c12
Compare
efriis
reviewed
May 7, 2024
libs/elasticsearch/tests/integration_tests/test_vectorstores.py
Outdated
Show resolved
Hide resolved
joemcelroy
approved these changes
May 7, 2024
maxjakob
force-pushed
the
use-orchestration-lib
branch
from
1a14907
to
142bfe9
Compare
This was referenced May 10, 2024
Closed
efriis
added a commit
to langchain-ai/langchain
that referenced
this pull request
May 17, 2024
Update documentation with the [new names for retrieval strategies](langchain-ai/langchain-elastic#22) --------- Co-authored-by: Erick Friis <[email protected]>
hinthornw
pushed a commit
to langchain-ai/langchain
that referenced
this pull request
Jun 20, 2024
Update documentation with the [new names for retrieval strategies](langchain-ai/langchain-elastic#22) --------- Co-authored-by: Erick Friis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved much of the VectorStore logic to the Elasticsearch client library (elastic/elasticsearch-py#2528, see module) in order to centralize the development, ensure all GenAI library integrations work the same and offer users direct access to this abstraction in the future.
This PR integrates the new module into LangChain and converts most tests to unit tests that just check if the backend vector store is called correctly (the integration tests now live in elasticsearch-py).
The LangChain classes keep their existing interfaces.