ElasticsearchStore async methods implementation #47
+1,236
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ElasticsearchStore
class inherits the async methods implemented inVectorStore
, that are actually not concurrent. The official Elasticsearch library now implements a helper for vector search, with both a sync and an async version, thanks to the developers oflangchain-elastic
!The goal of this PR is to better integrate the helper in
ElasticsearchStore
, so that its async methods can be overridden with proper implementations.I have considered different approaches, but there is critical difference in the design of the helper and the
VectorStore
class. The first has two completely independent classes for sync/async, the second exposes sync and async methods in the same abstraction. I am trying to follow the simplest approach possible, at the cost of:ElasticsearchStore
, even when only one of sync or async approach is usedElasticsearchStore
robust on legacy codeHope to receive feedback and improvement hints