fix _sparse_to_dict() misalign bug #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChengZi <[email protected]>
This was referenced Jan 16, 2025
|
This PR isn't included in the release version yet, right? |
sunwoongc
reviewed
Feb 4, 2025
| @@ -45,9 +56,4 @@ def embed_documents(self, texts: List[str]) -> List[Dict[int, float]]: | |||
| return [self._sparse_to_dict(sparse_array) for sparse_array in sparse_arrays] | |||
There was a problem hiding this comment.
I think in here, the sparse_arrays is <class 'scipy.sparse._csr.csr_array'>, though sparse_array is <class 'scipy.sparse._coo.coo_array'>, which raises an error.
I haven't your recommendation to read milvus document, but anyway, the issue can be resolved by changing the code to return [_sparse_to_dict(sparse_arrays)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.