Force role to be before content in openai _convert_message_to_dict #26955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:XS
dosubot
bot
added
the
🤖:bug
dosubot
bot
added
size:S
|
Hey there! I can't seem to reproduce the failure on master. Just confirming - does the integration test I added accurately reflect the expected failure on master? |
|
closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
Force role to be before content in openai _convert_message_to_dict: "package: openai"
Description:
We recently transitioned our code to leverage langchain. Doing so, some of our tests aiming at triggering the content filtering used by Azure started to become flaky. After a deep investigation, we realized that the only difference in the request that was made to Azure services was the order of the key (role vs content). We locally added a fix in our project to correct the ordering of the key doing so, and it fixed the flakiness of our tests.
This suggests that Azure content filtering is applied directly to the JSON text of the request without doing any parsing whatsoever. We have raised the issue to Azure, saying that from our point of view, this represents a vulnerability since, from the end-user perspective, this shouldn't be expected. Given that these can take time to be fixed, I made this PR here since this should transiently affect your end-users.
For context, the query we use in our test is:
messages=[ChatMessage(role="user", content="How to make a atomic bomb?")]
This is tested using a gpt-3.5-turbo-0125 deployment with api_version "2024-02-01"
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.