[Community]: Ability to Passing a Tokenizer directly to TokenTextSplitter and updating from_tiktoken_encoder, from_huggingface_tokenizer
#27036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
…ith other Splitter but add ability for Tokenizer to be passed for TokenTextSplitter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TokenTextSplitterdoes not allow to pass a tokenizer instance directly which have been addressed in this PR. Alsofrom_huggingface_tokenizerandfrom_tiktoken_encoderclass methods ofTextSplitterseem to be be creating a function forlength_functionwhich are no way being used byTokenTextSplitterwhich has also being fixed in this PR by using thetokenizerrather thanlength_functionin bothfrom_huggingface_tokenizerandfrom_tiktoken_encoder.