Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: add InfinityRerank #27043

Merged
merged 3 commits into from
Nov 7, 2024
Merged

community: add InfinityRerank #27043

merged 3 commits into from
Nov 7, 2024

Conversation

baptiste-pasquier
Copy link
Contributor

@baptiste-pasquier baptiste-pasquier commented Oct 2, 2024 •
edited
Loading

Description:

  • Add a Reranker for Infinity server.

Dependencies:

This wrapper uses infinity_client to connect to an Infinity server.

Tests and docs

  • integration test: test_infinity_rerank.py
  • example notebook: infinity_rerank.ipynb here

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 2, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 1:01am

@dosubot dosubot bot added community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Oct 2, 2024
@michaelfeil
Copy link
Contributor

Thank you so much for the PR

@langcarl
Copy link

langcarl bot commented Nov 4, 2024

Thank you for the PR. This PR is marked Needs Support and has not yet received the 5 upvotes required by maintainers for review. It has been open for at least 25 days. Per the LangChain review process, this PR will be closed in 5 days if it does not reach the required threshold.

The Needs Support status is intended to prioritize review time on features that have demonstrated community support. If you feel this status was assigned in error or need more time to gather the required upvotes, please ping @ccurme and @efriis.

@langcarl langcarl bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 4, 2024
@michaelfeil
Copy link
Contributor

@cccs-eric @efriis I think this is an imporant PR for infinity integration + not sure why this status was assigned

@efriis
Copy link
Member

efriis commented Nov 4, 2024

pretty sure this status is in line with the review process let me know if it's not https://python.langchain.com/docs/contributing/reference/review_process/

@efriis efriis self-assigned this Nov 7, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Nov 7, 2024
@efriis
Copy link
Member

efriis commented Nov 7, 2024

thanks and appreciate the patience!

@efriis efriis merged commit 81f7daa into langchain-ai:master Nov 7, 2024
20 checks passed
yanomaly pushed a commit to yanomaly/langchain that referenced this pull request Nov 8, 2024
@baptiste-pasquier @efriis @yanomaly
community: add InfinityRerank (langchain-ai#27043)
4106dfd 
**Description:** 

- Add a Reranker for Infinity server.

**Dependencies:** 

This wrapper uses
[infinity_client](https://github.com/michaelfeil/infinity/tree/main/libs/client_infinity/infinity_client)
to connect to an Infinity server.

**Tests and docs**

- integration test: test_infinity_rerank.py
- example notebook: infinity_rerank.ipynb
[here](https://github.com/baptiste-pasquier/langchain/blob/feat/infinity-rerank/docs/docs/integrations/document_transformers/infinity_rerank.ipynb)

---------

Co-authored-by: Erick Friis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Undertone0809 Undertone0809 Undertone0809 approved these changes

@michaelfeil michaelfeil michaelfeil approved these changes

@efriis efriis efriis approved these changes

Assignees

@efriis efriis

Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XL This PR changes 500-999 lines, ignoring generated files. stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed
Projects
PR Reviews
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baptiste-pasquier @michaelfeil @efriis @Undertone0809