community[patch]: Throw more descriptive errors for Ali toyi chat models #5549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:S
jacoblee93
reviewed
May 31, 2024
| @@ -593,7 +603,7 @@ export class ChatAlibabaTongyi | |||
| continue; | |||
| } | |||
| try { | |||
| yield JSON.parse(line.slice("data:".length).trim()); | |||
| yield JSON.parse(line.slice("data:".length)); | |||
There was a problem hiding this comment.
Why remove the trim call?
jacoblee93
reviewed
May 31, 2024
| "request_id": "43d18007-5aa5-9d18-b3b3-a55aba9ce8cb" | ||
| } | ||
| */ | ||
| if (!chunk.output) { |
There was a problem hiding this comment.
Is it safer to check for something like chunk.code?
jacoblee93
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw informative exception