Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(community): Update PrismaVectorStore to execute raw SQL with Prisma.sql tagged template #6889

Merged
merged 4 commits into from
Sep 30, 2024
Merged

fix(community): Update PrismaVectorStore to execute raw SQL with Prisma.sql tagged template #6889

merged 4 commits into from
Sep 30, 2024

Conversation

hmShuvo314
Copy link
Contributor

@hmShuvo314 hmShuvo314 commented Sep 26, 2024 •
edited
Loading

Fixed executing raw SQL queries within prisma.ts by integrating Prisma Client's sql method.

View Prisma.sql docs

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 26, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Sep 30, 2024 8:39pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Sep 30, 2024 8:39pm

@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Sep 26, 2024
@jacoblee93
Copy link
Collaborator

jacoblee93 commented Sep 27, 2024 •
edited
Loading

Thanks! Does this require a Prisma version bump as well?

I think you may also need to run yarn format - if you're unable I can have a look later.

@jacoblee93 jacoblee93 added the question Further information is requested label Sep 27, 2024
@jacoblee93 jacoblee93 changed the title Update PrismaVectorStore to execute raw SQL with Prisma.sql tagged template fix(community): Update PrismaVectorStore to execute raw SQL with Prisma.sql tagged template Sep 27, 2024
@hmShuvo314
Copy link
Contributor Author

Does this require a Prisma version bump as well?

Hello, while bumping up Prisma version is not required for this specific change, it is strongly recommended! Since Prisma is currently running on 5.20 and the codebase is still on much older 4.11.

Hope this helps! This issue has been a blocker for my own project. I am really looking forward to see it getting merged! Thank you!

@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 merged commit 4b00f3e into langchain-ai:main Sep 30, 2024
34 checks passed
FilipZmijewski pushed a commit to FilipZmijewski/langchainjs that referenced this pull request Oct 1, 2024
@hmShuvo314 @jacoblee93 @FilipZmijewski
fix(community): Update PrismaVectorStore to execute raw SQL with `Pri…
63d0f22 
…sma.sql` tagged template (langchain-ai#6889)

Co-authored-by: jacoblee93 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases question Further information is requested size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmShuvo314 @jacoblee93