Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create llm and embeddings implementation, include tests #6892

Closed
wants to merge 1 commit into from

Conversation

FilipZmijewski
Copy link
Contributor

Thank you for contributing to LangChain.js!

  • PR title: "package: description"

Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes.
Example: "community: add foobar LLM"

  • PR message:

Description: The aim of these changes is to create first Langchain.js by IBM implementation. Solutions applied consist of LLMs and embeddings.
fyi @LukaszCmielowski

  • Add tests and docs:

Expected tests for both of implemented features were added as well as README.md file.

  • Lint and test: Run yarn format, yarn lint, yarn test and yarn test:int from the root of the package(s) you've modified.

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Sep 27, 2024 1:16pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Sep 27, 2024 1:16pm

@FilipZmijewski FilipZmijewski marked this pull request as ready for review September 27, 2024 13:21
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Sep 27, 2024
@jacoblee93
Copy link
Collaborator

Hey @FilipZmijewski, thanks for the PR!

As discussed with some of your colleagues, it would be best to start with this in community - we don't currently have the resources for new integration packages in the monorepo.

@jacoblee93 jacoblee93 added the hold On hold label Sep 27, 2024
@jacoblee93 jacoblee93 closed this Oct 4, 2024
@langchain-ai langchain-ai locked as spam and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features hold On hold size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants