Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared state conceptual docs #1958
Shared state conceptual docs #1958
Changes from 3 commits
a78782c
02533a9
0460aee
ff54dcc
9c609d9
a7e59c9
3286136
05494ef
97029b0
4df8291
d9dc3fe
d999a6b
a611b50
e99a675
e21da04
2baeebe
e204940
e303117
509f7dc
3633017
9868b25
43b6e8e
9c004da
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's a single sentence answer to the question why is the key not a tuple? Why has the key been broken into a namespace (tuple) and a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda like files and folders, but there's not a super strong distinction in some cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does
search
return without a query?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it always returns a list of items. Default is listing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be by "updated_at" by default right now, though we haven't made an acceptance test suite for community stores so in theory they could make a non-compliant one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The full key words out to be:
Does structuring memories as:
work with respect to the memory store API? (e.g., does search work as expected etc.)
cc @hinthornw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can either put food preference in the namespace (so you can search in that directory) or as a key and do filter of {"type", "food_preference"}
More flexible if it's in the body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
list
API. Doessearch
support queries?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not yet - just filtering, limit, offset.
search query & additional things to be added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The input into the graph is messages in the format of dicts.
I think that the schema of the graph is MessagesState -- which doesn't support the dict notation probably?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @vbarda / @hinthornw IMO this is a problem if we start using dict notation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just ran into mypy anger from this type of thing where BaseMessgae isn't included either.
I think we can use
from langgraph.graph.mesages import Messages
which is a union of that and "messagelikedict" or somethingIt's frustrating that core doesn't have a single type for this