use langsmith env vars #373
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
pr doesn't touch: imo these should also be updated to use LANGSMITH prefix but seems like bigger change? |
jacoblee93
reviewed
Jul 29, 2024
| @@ -88,8 +88,8 @@ for input_prompt, output_answer in example_inputs: | |||
| )`), | |||
There was a problem hiding this comment.
No need to update old docs, not sure when support was added anyway
jacoblee93
reviewed
Jul 29, 2024
| @@ -26,9 +26,9 @@ If you are using LangChain (either Python or JS/TS), you can skip this section a | |||
| LangSmith makes it easy to log traces with minimal changes to your existing code with the `@traceable` decorator in Python and `traceable` function in TypeScript. | |||
|
|
|||
| :::note | |||
| The `LANGCHAIN_TRACING_V2` environment variable must be set to `'true'` in order for traces to be logged to LangSmith, even when using `@traceable` or `traceable`. This allows you to toggle tracing on and off without changing your code. | |||
| The `LANGSMITH_TRACING` environment variable must be set to `'true'` in order for traces to be logged to LangSmith, even when using `@traceable` or `traceable`. This allows you to toggle tracing on and off without changing your code. | |||
There was a problem hiding this comment.
Bearing in mind recent feedback about things changing without warning - can we add a callout documenting that the old variables will still work?
|
It looks like
|
|
I would change in the SDK first, let it bake a while, then change docs later |
|
The changes in the SDK should bw-compat, the older env vars should still be respected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
not sure all of these actually work across py and js