Skip to content

Commit

Permalink
refactor: remove unnecessary 'client' fixture and update test duratio…
Browse files Browse the repository at this point in the history
…ns (#4283)

* Remove unnecessary use of 'client' fixture in test_superuser

* Remove unnecessary use of 'usefixtures' decorator in test files

* Update test fixtures to improve test duration tracking

* Remove unnecessary 'client' fixture from test cases
  • Loading branch information
ogabrielluiz authored Oct 27, 2024
1 parent 1ef1fcb commit 73b5cc0
Show file tree
Hide file tree
Showing 6 changed files with 601 additions and 605 deletions.
1,200 changes: 600 additions & 600 deletions src/backend/tests/.test_durations

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def test_component_tool():


@pytest.mark.api_key_required
@pytest.mark.usefixtures("_add_toolkit_output", "client")
@pytest.mark.usefixtures("_add_toolkit_output")
def test_component_tool_with_api_key():
chat_output = ChatOutput()
openai_llm = OpenAIModelComponent()
Expand Down
1 change: 0 additions & 1 deletion src/backend/tests/unit/graph/edge/test_edge_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from langflow.graph import Graph


@pytest.mark.usefixtures("client")
def test_edge_raises_error_on_invalid_target_handle():
template = """Answer the user as if you were a pirate.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ def memory_chatbot_graph():
return graph


@pytest.mark.usefixtures("client")
def test_memory_chatbot(memory_chatbot_graph):
# Now we run step by step
expected_order = deque(["chat_input", "chat_memory", "prompt", "openai", "chat_output"])
Expand Down
1 change: 0 additions & 1 deletion src/backend/tests/unit/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ def test_components_path(runner, default_settings, tmp_path):
assert str(temp_dir) in settings_service.settings.components_path


@pytest.mark.usefixtures("client")
def test_superuser(runner):
result = runner.invoke(app, ["superuser"], input="admin\nadmin\n")
assert result.exit_code == 0, result.stdout
Expand Down
1 change: 0 additions & 1 deletion src/backend/tests/unit/test_database.py
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,6 @@ async def test_load_flows(client: TestClient):
assert response.json()["folder_id"] is not None


@pytest.mark.usefixtures("client")
def test_sqlite_pragmas():
db_service = get_db_service()

Expand Down

0 comments on commit 73b5cc0

Please sign in to comment.