-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new .env variable "LANGFLOW_FEATURE_MVP_COMPONENTS" to show/hide integration sidebar components #4270
Open
Cristhianzl
wants to merge
16
commits into
main
Choose a base branch
from
cz/mvp-components-flags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uthentication 🔧 (api.tsx): Replace universal-cookie import with react-cookie for consistency 🔧 (authStore.ts): Replace universal-cookie import with react-cookie for consistency 🔧 (use-get-global-variables.ts): Add check to only fetch global variables if user is authenticated ✨ (use-get-mutation-global-variables.ts): Add mutation function to fetch and update global variables 🔧 (authStore.ts): Replace universal-cookie import with react-cookie for consistency
📝 (endpoints.py): modify get_config function to include feature_flags in the response 📝 (feature_flags.py): add mvp_components field to FeatureFlags settings 📝 (schemas.py): add feature_flags field to ConfigResponse schema
…rface to support feature flags in the application 🔧 (utilityStore.ts): Add featureFlags field and setFeatureFlags function to utilityStore to manage feature flags in the application 💡 (extraSidebarComponent/index.tsx): Use featureFlags from utilityStore to conditionally render components based on feature flags in ExtraSidebar component
…de-supported package to clean up unnecessary information
…rect visibility of integrations in the sidebar based on the value of mvp_components.
…o use feature_flags object for mvp_components flag for better readability and maintainability.
…the API call to improve test reliability
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Oct 24, 2024
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Oct 24, 2024
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
documentation
Improvements or additions to documentation
labels
Oct 24, 2024
Hi @Cristhianzl wondering if this PR will cover this request: #2597 ? |
ogabrielluiz
requested changes
Oct 24, 2024
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Oct 24, 2024
dosubot
bot
removed
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Oct 24, 2024
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Oct 24, 2024
hey @codenprogressive, I'm sorry, but no! |
ogabrielluiz
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new .env variable: LANGFLOW_FEATURE_MVP_COMPONENTS. This variable will allow for the dynamic control of displaying or hiding the integration sidebar components based on the environment configuration.
Key Changes
How to Use
Add LANGFLOW_FEATURE_MVP_COMPONENTS=true or LANGFLOW_FEATURE_MVP_COMPONENTS=false to your .env file.
When set to true, the integration sidebar components will be visible.
When set to false, the integration sidebar components will be hidden.