feat: Added alembic log path as env var change #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
devinbost
force-pushed
the
alembic_log_path
branch
from
2a25495
to
09272dc
Compare
dosubot
bot
added
size:XS
ogabrielluiz
changed the title
github-actions
bot
added
enhancement
cbornet
requested changes
Oct 26, 2024
| @@ -44,6 +44,11 @@ def __init__(self, settings_service: SettingsService): | |||
| self.script_location = langflow_dir / "alembic" | |||
| self.alembic_cfg_path = langflow_dir / "alembic.ini" | |||
| self.engine = self._create_engine() | |||
| if self.settings_service.settings.alembic_log_file.startswith("/"): | |||
There was a problem hiding this comment.
Use the cross-platform Path.is_absolute()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OpenShift, we needed a way to override the default alembic log directory with a path that exists on a non-read-only filesystem (i.e. on a mounted path). This change (if it does what it's intended to do) will enable that.
Intended to fix: #4235