-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance backend with context management, error handling, and refactored code #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
enhancement
New feature or request
labels
Oct 25, 2024
ogabrielluiz
force-pushed
the
feat-context
branch
from
October 25, 2024 14:51
a547195
to
d5f03a2
Compare
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Oct 25, 2024
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:XXL
This PR changes 1000+ lines, ignoring generated files.
labels
Oct 25, 2024
ogabrielluiz
changed the title
feat: Enhance backend with improved context management, error handling, and refactored code
feat: Enhance backend with context management, error handling, and refactored code
Oct 25, 2024
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Oct 25, 2024
italojohnny
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ogabrielluiz
force-pushed
the
feat-context
branch
2 times, most recently
from
October 28, 2024 17:47
1d49939
to
573afac
Compare
…and context management - Introduced `AgentActionRouter` to route agent flow based on action type. - Added `DecideActionComponent` for determining actions from context and prompts. - Implemented `ExecuteActionComponent` to execute actions using available tools. - Created `GenerateThoughtComponent` for generating thoughts based on context. - Developed `ProvideFinalAnswerComponent` to generate final answers from context. - Built `AgentContextBuilder` for constructing `AgentContext` instances. - Added `ObserveResultComponent` to process and observe action results. - Implemented `CheckTerminationComponent` to determine if the agent should continue or terminate.
…tion - Introduced `AgentContext` class in `context.py` to handle agent state, including tools, language model, and context history. - Implemented serialization methods for converting agent context to JSON-compatible format. - Added validation for language model instances to ensure compatibility. - Provided methods for updating and retrieving full context, including context history management.
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Nov 4, 2024
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:XL
This PR changes 500-999 lines, ignoring generated files.
labels
Nov 5, 2024
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Nov 5, 2024
italojohnny
approved these changes
Nov 5, 2024
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:XL
This PR changes 500-999 lines, ignoring generated files.
labels
Nov 7, 2024
ogabrielluiz
requested review from
italojohnny and
edwinjosechittilappilly
and removed request for
jordanrfrazier
November 7, 2024 21:36
italojohnny
approved these changes
Nov 8, 2024
CodSpeed Performance ReportMerging #4286 will degrade performances by 14.64%Comparing Summary
Benchmarks breakdown
|
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
…factored code (langflow-ai#4286) * Add cycle detection and management for graph vertices in run manager * Refactor: Move AIMLEmbeddingsImpl to a new module path * Add AIMLEmbeddingsImpl class for document and query embeddings using AIML API * Add agent components for action routing, decision-making, execution, and context management - Introduced `AgentActionRouter` to route agent flow based on action type. - Added `DecideActionComponent` for determining actions from context and prompts. - Implemented `ExecuteActionComponent` to execute actions using available tools. - Created `GenerateThoughtComponent` for generating thoughts based on context. - Developed `ProvideFinalAnswerComponent` to generate final answers from context. - Built `AgentContextBuilder` for constructing `AgentContext` instances. - Added `ObserveResultComponent` to process and observe action results. - Implemented `CheckTerminationComponent` to determine if the agent should continue or terminate. * Add AgentContext class for managing agent state and context serialization - Introduced `AgentContext` class in `context.py` to handle agent state, including tools, language model, and context history. - Implemented serialization methods for converting agent context to JSON-compatible format. - Added validation for language model instances to ensure compatibility. - Provided methods for updating and retrieving full context, including context history management. * Add new agent components to the langflow module's init file * Update `apply_on_outputs` to use `_outputs_map` in vertex base class * Add _pre_run_setup method to custom component for pre-execution setup * Handle non-list action types in decide_action method * Enhance AgentActionRouter with iteration control and context routing logic * Fix incorrect variable usage in tool call result message formatting * Add AgentActionRouter to module exports in agents package * Refactor cycle detection logic in graph base class * Add test for complex agent flow with cyclic graph validation * Enhance readiness checks in tracing service methods * Add context management to Graph class with dotdict support * Add context management methods to custom component class - Introduced a `_ctx` attribute to store context data. - Added `ctx` property to access the graph's context, raising an error if the graph is not built. - Implemented `add_to_ctx` method to add key-value pairs to the context with an optional overwrite flag. - Implemented `update_ctx` method to update the context with a dictionary of values, ensuring the graph is built and the input is a dictionary. * Add customizable Agent component with input/output handling and action routing * Handle non-list 'tools' attribute in 'build_context' method * Convert `get_response` method to asynchronous and update graph processing to use async iteration. * Add async test for Agent component in graph cycle tests * Refactor Agent Flow JSON: Simplify input types and update agent component structure - Removed "BaseTool" from input types for "ToolCallingAgent" to streamline tool handling. - Updated agent component to a more modular structure with new prompts and input configurations. - Replaced deprecated methods and fields with updated implementations for improved functionality. - Adjusted metadata and configuration settings for better clarity and usability. * [autofix.ci] apply automated fixes * Add Agent import to init, improve error handling, and clean up imports - Added `Agent` import to `__init__.py` for better module accessibility. - Improved error handling in `aiml_embeddings.py` by raising a `ValueError` when the expected embedding count is not met. - Cleaned up redundant imports in `test_cycles.py` to enhance code readability. * Refactor agent component imports for improved modularity and organization * Remove agent components and update `__init__.py` exports * Add iteration control and default route options to ConditionalRouter component * Refactor graph tests to include new components and update iteration logic - Replaced complex agent flow with a simplified guessing game using OpenAI components and conditional routing. - Introduced `TextInputComponent` and updated `ChatInput` initialization. - Added new test `test_conditional_router_max_iterations` to validate conditional routing with max iterations. - Updated graph cyclicity assertions and snapshot checks for improved test coverage. - Removed deprecated agent components and related logic. * Refactor conditional router to return message consistently and use iterate_and_stop_once method * Add return type annotations to methods in langsmith.py * Remove unnecessary `@override` decorator and add `# noqa: ARG002` comments for unused arguments * Move ChatInput import inside flow_component fixture in conftest.py * Update test to use _outputs_map for cycle outputs retrieval * Refactor `iterate_and_stop_once` to remove redundant `_id` variable usage * Add default route to ConditionalRouterComponent in cycle test * Implement synchronous graph execution using threading and queues - Removed `nest_asyncio` dependency and replaced it with a new threading-based approach for synchronous graph execution. - Introduced a `queue.Queue` to handle results and exceptions between threads. - Added a new thread to run asynchronous code, ensuring proper event loop management and task completion. - Updated methods to return sorted lists of runnable vertices for consistency. * Update import path for ModelConstants in test_model_constants.py * [autofix.ci] apply automated fixes * fix: add property decorator --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: italojohnny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the backend, focusing on enhancing context management, improving error handling, and refactoring code for better maintainability. The most important changes include the introduction of the
AgentContext
class, updates to theComponent
class for context handling, and various improvements to the graph and tracing services.Check the added test for an example use case of the context.
Context Management Enhancements:
src/backend/base/langflow/base/agents/context.py
: Introduced theAgentContext
class to manage agent context, including serialization and validation of language models.src/backend/base/langflow/custom/custom_component/component.py
: Added methods to theComponent
class for managing context, includingadd_to_ctx
,update_ctx
, and_pre_run_setup
. [1] [2] [3]Error Handling Improvements:
src/backend/base/langflow/base/embeddings/aiml_embeddings.py
: Enhanced error messages inembed_documents
to provide more detailed information.Code Refactoring:
src/backend/base/langflow/components/embeddings/aiml.py
: Refactored imports to use the new module structure forAIMLEmbeddingsImpl
.src/backend/base/langflow/components/embeddings/util/__init__.py
: Removed redundant import forAIMLEmbeddingsImpl
.Graph Improvements:
src/backend/base/langflow/graph/graph/base.py
: Added context handling to theGraph
class and improved cycle detection logic. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]src/backend/base/langflow/graph/graph/runnable_vertices_manager.py
: Added support for managing vertices in cycles. [1] [2] [3]Tracing Service Updates:
src/backend/base/langflow/services/tracing/langsmith.py
: Improved tracing service to handle scenarios where the run tree is not ready. [1] [2] [3]