feat: Raise exception in tests when blocking code is called in event loop #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
cbornet
force-pushed
the
detect-blocking
branch
from
a3487cf
to
1449e96
Compare
cbornet
commented
Oct 26, 2024
|
|
||
|
|
||
| def init(): | ||
| time.sleep = _raise_if_blocking(time.sleep) |
There was a problem hiding this comment.
One drawback of patching time.sleep is that debugging with breakpoints in test will raise the BlockingError.
So this behavior should probably be configurable.
There was a problem hiding this comment.
Maybe a fixture? I debug a lot through tests
There was a problem hiding this comment.
Yes, me too.
Maybe there could be en env var RAISE_ON_BLOCKING_TIME_SLEEP that we set by default to false. And that we set to true in CI ?
cbornet
force-pushed
the
detect-blocking
branch
from
1449e96
to
7837c19
Compare
cbornet
commented
Oct 26, 2024
| @@ -93,15 +94,16 @@ async def _queue_event(self, payload) -> None: | |||
| async def log_package_version(self) -> None: | |||
| python_version = ".".join(platform.python_version().split(".")[:2]) | |||
| version_info = get_version_info() | |||
| architecture = platform.architecture()[0] | |||
There was a problem hiding this comment.
Detected by the block buster 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.