ref: simplify docker build workflow #4294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
jordanrfrazier
commented
Oct 26, 2024
| @@ -254,74 +224,9 @@ jobs: | |||
| # provenance: false will result in a single manifest for all platforms which makes the image pullable from arm64 machines via the emulation (e.g. Apple Silicon machines) | |||
| provenance: false | |||
|
|
|||
| build_components: | |||
There was a problem hiding this comment.
@ogabrielluiz I removed this step. I don't know what these images are used for.
There was a problem hiding this comment.
IIRC, these were added to support deployment in DS LF, I'm not sure if they are used at all but I was hoping to create a template in Railway with a decoupled frontend so we could scale the backend with a reverse proxy like NGINX
ogabrielluiz
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the Docker build and push workflows, primarily focusing on enhancing the flexibility and clarity of version and release type handling. The most important changes include renaming and adding new input parameters, updating job steps to accommodate these changes, and refining the tagging and versioning logic.
Enhancements to Input Parameters:
versiontomain_versionand addedbase_versionwith detailed descriptions for better clarity. (.github/workflows/docker-build.yml, .github/workflows/docker-build.ymlL5-R48)release_typeparameter to include more detailed descriptions and added arefparameter to specify the reference to check out. (.github/workflows/docker-build.yml, .github/workflows/docker-build.ymlL5-R48)Updates to Job Steps:
Resolve nightly tagstep and replaced it with a verification step to ensure a main version exists. (.github/workflows/docker-build.yml, .github/workflows/docker-build.ymlL63-R126)Get Version to Tagstep to handle bothmain_versionandbase_versionappropriately based on the release type. (.github/workflows/docker-build.yml, .github/workflows/docker-build.ymlL63-R126).github/workflows/docker-build.yml, .github/workflows/docker-build.ymlL211-R187)Refinements to Tagging and Versioning Logic:
latesttag for pre-releases. (.github/workflows/docker-build.yml, .github/workflows/docker-build.ymlL186-R157).github/workflows/docker-build.yml, .github/workflows/docker-build.ymlL174-R144)Changes to Release Workflow:
main_versionandbase_versionparameters, ensuring that both base and main versions are passed correctly. (.github/workflows/release.yml, .github/workflows/release.ymlL192-R218)