-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: simplify docker build workflow #4294
base: main
Are you sure you want to change the base?
Conversation
@@ -254,74 +224,9 @@ jobs: | |||
# provenance: false will result in a single manifest for all platforms which makes the image pullable from arm64 machines via the emulation (e.g. Apple Silicon machines) | |||
provenance: false | |||
|
|||
build_components: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ogabrielluiz I removed this step. I don't know what these images are used for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, these were added to support deployment in DS LF, I'm not sure if they are used at all but I was hoping to create a template in Railway with a decoupled frontend so we could scale the backend with a reverse proxy like NGINX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
btw, we can add an entrypoint to the default image if you like
This pull request includes significant updates to the Docker build and push workflows, primarily focusing on enhancing the flexibility and clarity of version and release type handling. The most important changes include renaming and adding new input parameters, updating job steps to accommodate these changes, and refining the tagging and versioning logic.
Enhancements to Input Parameters:
version
tomain_version
and addedbase_version
with detailed descriptions for better clarity. (.github/workflows/docker-build.yml
, .github/workflows/docker-build.ymlL5-R48)release_type
parameter to include more detailed descriptions and added aref
parameter to specify the reference to check out. (.github/workflows/docker-build.yml
, .github/workflows/docker-build.ymlL5-R48)Updates to Job Steps:
Resolve nightly tag
step and replaced it with a verification step to ensure a main version exists. (.github/workflows/docker-build.yml
, .github/workflows/docker-build.ymlL63-R126)Get Version to Tag
step to handle bothmain_version
andbase_version
appropriately based on the release type. (.github/workflows/docker-build.yml
, .github/workflows/docker-build.ymlL63-R126).github/workflows/docker-build.yml
, .github/workflows/docker-build.ymlL211-R187)Refinements to Tagging and Versioning Logic:
latest
tag for pre-releases. (.github/workflows/docker-build.yml
, .github/workflows/docker-build.ymlL186-R157).github/workflows/docker-build.yml
, .github/workflows/docker-build.ymlL174-R144)Changes to Release Workflow:
main_version
andbase_version
parameters, ensuring that both base and main versions are passed correctly. (.github/workflows/release.yml
, .github/workflows/release.ymlL192-R218)