Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding possibility to enforce JSON format in VertexAiModel #5290

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: adding possibility to enforce JSON format in VertexAiModel #5290

wants to merge 3 commits into from
+10 −0

Conversation

severfire
Copy link

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Dec 16, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 16, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 16, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 19, 2024
ogabrielluiz
ogabrielluiz approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @severfire !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 24, 2024
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Dec 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 24, 2024
@severfire
Copy link
Author

severfire commented Dec 24, 2024 •
edited
Loading

@ogabrielluiz Thanks! I think I should add also 'response_schema', which I will do after Christmas :-) Have Merry Christmas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@severfire @ogabrielluiz