fix: Add factor to prevent overlap #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
github-actions
bot
added
bug
ogabrielluiz
previously requested changes
Dec 28, 2024
This commit adds the buildPositionDictionary function to reactflowUtils.ts. This function is used to build a dictionary of positions for nodes in the flow. It is necessary for managing the positions of nodes and preventing overlap.
dosubot
bot
added
size:M
github-actions
bot
added
bug
github-actions
bot
added
bug
This commit adds the setPositionDictionary function to the PageComponent in order to set the position dictionary for the flow. This function is used to update the position dictionary when the canvas is moved or resized. Co-authored-by: [Author Name]
github-actions
bot
added
bug
github-actions
bot
added
bug
|
nice catch @jordanrfrazier, and it will require less dependencies |
anovazzi1
changed the title
github-actions
bot
added
bug
github-actions
bot
added
bug
jordanrfrazier
approved these changes
Jan 6, 2025
github-actions
bot
added
bug
anovazzi1
dismissed
ogabrielluiz’s stale review
the review is outadted to the current version
github-actions
bot
added
bug
ogabrielluiz
pushed a commit
to raphaelchristi/langflow
that referenced
this pull request
Jan 10, 2025
* fix: add random factor to prevent overlap * update package.lock * feat: Add positionDictionary and related functions to FlowStoreType * feat: Add buildPositionDictionary function to reactflowUtils.ts * feat: Add buildPositionDictionary function to reactflowUtils.ts This commit adds the buildPositionDictionary function to reactflowUtils.ts. This function is used to build a dictionary of positions for nodes in the flow. It is necessary for managing the positions of nodes and preventing overlap. * fix: Remove random factor from paste function in PageComponent * [autofix.ci] apply automated fixes * feat: Add setPositionDictionary function to PageComponent This commit adds the setPositionDictionary function to the PageComponent in order to set the position dictionary for the flow. This function is used to update the position dictionary when the canvas is moved or resized. Co-authored-by: [Author Name] * [autofix.ci] apply automated fixes * Refactor position calculation in useFlowStore * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where there was potential overlap when pasting a copied selection. The commit adds a random factor to the x and y coordinates of the pasted selection, preventing overlap.