Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preserve manual component data if code unchanged #5482

Merged
merged 18 commits into from
Jan 20, 2025

Conversation

italojohnny
Copy link
Member

This PR updates the backend logic to preserve certain fields (display_name, description, and tool_mode) of frontend components when their code has not been modified. This ensures that user-provided values are not overwritten unnecessarily.

Frontend adjustments will be required to properly utilize the preserved data.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 30, 2024
Copy link

codspeed-hq bot commented Dec 30, 2024

CodSpeed Performance Report

Merging #5482 will improve performances by 12.57%

Comparing chore/preserve-component-data (9f510de) with main (c1cec32)

Summary

⚡ 1 improvements
✅ 14 untouched benchmarks

Benchmarks breakdown

Benchmark main chore/preserve-component-data Change
test_get_and_cache_all_types_dict 1,117.9 µs 993 µs +12.57%

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we will just have to change it so that the parameters are maintained when the user updates the code manually as well. Also, could you maybe implement a logic to just update the description if the description of the new code is different than the description of the old code please?
Thanks!

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 8, 2025
@ogabrielluiz ogabrielluiz changed the title chore: preserve manual component data if code unchanged feat: preserve manual component data if code unchanged Jan 13, 2025
@github-actions github-actions bot added enhancement New feature or request and removed ignore-for-release enhancement New feature or request labels Jan 13, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 13, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 15, 2025
@italojohnny italojohnny disabled auto-merge January 17, 2025 16:22
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 17, 2025
@italojohnny italojohnny force-pushed the chore/preserve-component-data branch from bdc0b74 to b1d9f0d Compare January 20, 2025 11:24
@italojohnny italojohnny enabled auto-merge January 20, 2025 11:25
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 20, 2025
@italojohnny italojohnny added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit c8eb408 Jan 20, 2025
38 checks passed
@italojohnny italojohnny deleted the chore/preserve-component-data branch January 20, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants