fix: Improve data consistency in update_flow function #5516

Cristhianzl · 2025-01-02T16:24:41Z

This pull request includes several changes to the update_flow function and a utility function in the backend of the Langflow API. The modifications aim to improve error handling, ensure data integrity, and enhance functionality.

Improvements to `update_flow` function:

Added a check to set flow.data to db_flow.data if it is None to ensure data consistency.
Added a return statement to return db_flow after committing the session, ensuring the updated flow is returned.
Moved the session rollback inside the except block to handle errors more gracefully and ensure the database state is not corrupted.

Enhancements to utility function:

Added a check for the presence of "nodes" in flow_data to prevent potential attribute errors in the get_webhook_component_in_flow function.

…d in the database during flow update 📝 (flows.py): Improve error handling and rollback database session in case of exceptions during flow update 📝 (flows.py): Refactor code to handle unique constraint errors and provide more informative error messages 📝 (utils.py): Refactor get_webhook_component_in_flow function to handle cases where flow_data may not have 'nodes' attribute

codspeed-hq · 2025-01-02T16:38:24Z

CodSpeed Performance Report

Merging #5516 will improve performances by 26.12%

_{Comparing cz/fix-move-flow-folder (57d562b) with main (70eaacf)}

Summary

⚡ 2 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

	Benchmark	`main`	`cz/fix-move-flow-folder`	Change
⚡	`test_get_and_cache_all_types_dict`	1.3 ms	1 ms	+26.12%
⚡	`test_successful_run_with_output_type_debug`	352.5 ms	299.7 ms	+17.63%

…r folder buttons for improved accessibility and testing ✨ (general-bugs-move-flow-from-folder.spec.ts): add test to ensure user can move flow from one folder to another in the frontend application

…-ai/langflow into cz/fix-move-flow-folder

src/backend/base/langflow/api/v1/flows.py

…l data inconsistency ♻️ (service.py): refactor with_session method to handle session commit and rollback more effectively

…-ai/langflow into cz/fix-move-flow-folder

…ption handling for better error propagation and clarity

src/backend/base/langflow/services/database/service.py

ogabrielluiz · 2025-01-09T14:24:51Z

src/backend/base/langflow/api/v1/flows.py

+        if flow.data is None:
+            flow.data = db_flow.data


if we are saving db_flow, why are we setting this here?

Can't we just do something like `flow.model_dump(exclude_unset=True, exclude_none=True?)

this is because in some cases, the frontend needs to update parts of the flow (such as the description or name) without sending all the data to the backend. In these situations, we must retrieve the data from the database to save the changes..

But the db_flow is the one being added to the database already.

We are putting db_flow data into flow then saving db_flow. We don't need to do that.

Again: can't we just do something like flow.model_dump(exclude_unset=True, exclude_none=True)?

Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>

ogabrielluiz · 2025-01-10T18:50:20Z

src/backend/base/langflow/api/v1/flows.py

+        if flow.data is None:
+            flow.data = db_flow.data


But the db_flow is the one being added to the database already.

ogabrielluiz · 2025-01-10T18:51:07Z

src/backend/base/langflow/api/v1/flows.py

+        if flow.data is None:
+            flow.data = db_flow.data


We are putting db_flow data into flow then saving db_flow. We don't need to do that.

Again: can't we just do something like flow.model_dump(exclude_unset=True, exclude_none=True)?

Cristhianzl requested review from italojohnny and ogabrielluiz January 2, 2025 16:24

Cristhianzl self-assigned this Jan 2, 2025

dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jan 2, 2025

github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 2, 2025

Merge branch 'main' into cz/fix-move-flow-folder

f187fb7

Cristhianzl marked this pull request as draft January 2, 2025 16:26

github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 2, 2025

Cristhianzl added 2 commits January 2, 2025 14:41

✨ (sideBarFolderButtons/index.tsx): add unique id attribute to sideba…

776b594

…r folder buttons for improved accessibility and testing ✨ (general-bugs-move-flow-from-folder.spec.ts): add test to ensure user can move flow from one folder to another in the frontend application

Merge branch 'cz/fix-move-flow-folder' of https://github.com/langflow…

fbeebe1

…-ai/langflow into cz/fix-move-flow-folder

github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 2, 2025

Cristhianzl marked this pull request as ready for review January 2, 2025 18:16

Merge branch 'main' into cz/fix-move-flow-folder

57d562b

github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 2, 2025

ogabrielluiz requested changes Jan 3, 2025

View reviewed changes

src/backend/base/langflow/api/v1/flows.py Outdated Show resolved Hide resolved

Cristhianzl added 2 commits January 3, 2025 09:49

🐛 (flows.py): remove unnecessary session rollback to prevent potentia…

60e1bdd

…l data inconsistency ♻️ (service.py): refactor with_session method to handle session commit and rollback more effectively

Merge branch 'cz/fix-move-flow-folder' of https://github.com/langflow…

f1e811e

…-ai/langflow into cz/fix-move-flow-folder

github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 3, 2025

Merge branch 'main' into cz/fix-move-flow-folder

5f79e98

github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 6, 2025

Merge branch 'main' into cz/fix-move-flow-folder

a6ba7d0