Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds test cases for loop component compatibility with the APIs #5615

Open
wants to merge 17 commits into
base: loop-component
Choose a base branch
from

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request introduces a new test for loop functionality in the backend tests. The changes include adding a new test file, updating existing test configurations, and creating new fixtures.

New Test Functionality:

Test Configuration Updates:

  • src/backend/tests/conftest.py: Added a new test data file LoopTest.json and created a new fixture json_loop_test for it. Updated the pytest_configure function and the get_text function to include the new test data file. [1] [2] [3]

@edwinjosechittilappilly edwinjosechittilappilly marked this pull request as ready for review January 9, 2025 20:14
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 9, 2025
@github-actions github-actions bot added the enhancement New feature or request label Jan 9, 2025
@edwinjosechittilappilly edwinjosechittilappilly changed the title feat: add test cases for loop component tests with the API feat: adds test cases for loop component compatibility with the APIs Jan 9, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 9, 2025
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the TestBatchRunComponent test and build these tests using the same structure?

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
Copy link

codspeed-hq bot commented Jan 10, 2025

CodSpeed Performance Report

Merging #5615 will not alter performance

Comparing fix-loop (a161193) with main (45ed8e5)

Summary

✅ 15 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark main fix-loop Change
🆕 test_build_flow_loop N/A 977.7 ms N/A

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 10, 2025
@github-actions github-actions bot removed the enhancement New feature or request label Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

The test has been updated.

The first test with the build endpoint passes
Where as the second test is the one that fails since the output from loop is empty.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants