-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance URL component with improved description and render parameters #5623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to improve clarity and consistency 📝 (Graph Vector Store RAG.json): Update description of URLComponent class to improve clarity and consistency 📝 (select-items.tsx): Change noteDataType import to NoteDataType for consistency and clarity 📝 (dropdown-menu.tsx): Add RenderIcons component to display keyboard shortcuts for actions 📝 (index.tsx): Change parameter type from React.MouseEvent to KeyboardEvent for removeInput and handleDuplicateInput functions 📝 (use-overlap-shortcuts.tsx): Create custom hook to handle keyboard shortcuts with support for multiple key variations and modifiers
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
enhancement
New feature or request
labels
Jan 10, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 10, 2025
CodSpeed Performance ReportMerging #5623 will degrade performances by 43.83%Comparing Summary
Benchmarks breakdown
|
… files 📝 (frontend): Refactor input components to use listAddLabel instead of metadata in multiple files
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 10, 2025
…lean up the code and improve readability
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 10, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 10, 2025
lucaseduoli
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 10, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 10, 2025
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
size:XXL
This PR changes 1000+ lines, ignoring generated files.
labels
Jan 10, 2025
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 10, 2025
…ngflow into cz/new-input-list
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 10, 2025
…z/new-input-list
…nections 💡 (generalBugs-shard-5.spec.ts): add clarifying comments for connection steps in the test case
…hor-input to resolve UI bug 📝 (generalBugs-shard-5.spec.ts): update test cases to improve test coverage and accuracy
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 10, 2025
…odeOutputField component 🔧 (generalBugs-shard-5.spec.ts): Remove commented out code related to input filling and waiting for visibility to clean up the test file and improve readability
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 10, 2025
… class to improve spacing for better user experience
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the URL component and its associated metadata in various starter project JSON files. The most important changes involve updating the description of the URL component and adding render parameters for better user interface interaction.
Updates to URL component:
src/backend/base/langflow/components/data/url.py
: Updated the description of theURLComponent
to "Load and retrieve data from specified URLs" and added metadata forrender_parameters
includingplaceholder
andbutton_text
.Updates to starter project JSON files:
src/backend/base/langflow/initial_setup/starter_projects/Blog Writer.json
: Updated the metadata for the URL component to includerender_parameters
withbutton_text
andplaceholder
. [1] [2]src/backend/base/langflow/initial_setup/starter_projects/Custom Component Maker.json
: Updated the metadata for the URL component across multiple sections to includerender_parameters
withbutton_text
andplaceholder
. [1] [2] [3] [4] [5]