Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance URL component with improved description and render parameters #5623

Merged
merged 17 commits into from
Jan 10, 2025

Conversation

Cristhianzl
Copy link
Member

@Cristhianzl Cristhianzl commented Jan 10, 2025

This pull request includes updates to the URL component and its associated metadata in various starter project JSON files. The most important changes involve updating the description of the URL component and adding render parameters for better user interface interaction.

Updates to URL component:

Updates to starter project JSON files:

image

image

…s to improve clarity and consistency

📝 (Graph Vector Store RAG.json): Update description of URLComponent class to improve clarity and consistency
📝 (select-items.tsx): Change noteDataType import to NoteDataType for consistency and clarity
📝 (dropdown-menu.tsx): Add RenderIcons component to display keyboard shortcuts for actions
📝 (index.tsx): Change parameter type from React.MouseEvent to KeyboardEvent for removeInput and handleDuplicateInput functions
📝 (use-overlap-shortcuts.tsx): Create custom hook to handle keyboard shortcuts with support for multiple key variations and modifiers
@Cristhianzl Cristhianzl self-assigned this Jan 10, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement New feature or request labels Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
Copy link

codspeed-hq bot commented Jan 10, 2025

CodSpeed Performance Report

Merging #5623 will degrade performances by 43.83%

Comparing cz/new-input-list (3f46b5e) with main (517961d)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cz/new-input-list Change
test_get_and_cache_all_types_dict 1.2 ms 2.2 ms -43.83%
test_successful_run_with_input_type_any 175.2 ms 255.5 ms -31.44%
test_successful_run_with_input_type_text 333.3 ms 248.8 ms +33.94%

… files

📝 (frontend): Refactor input components to use listAddLabel instead of metadata in multiple files
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
…nections

💡 (generalBugs-shard-5.spec.ts): add clarifying comments for connection steps in the test case
…hor-input to resolve UI bug

📝 (generalBugs-shard-5.spec.ts): update test cases to improve test coverage and accuracy
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
…odeOutputField component

🔧 (generalBugs-shard-5.spec.ts): Remove commented out code related to input filling and waiting for visibility to clean up the test file and improve readability
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
… class to improve spacing for better user experience
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
@Cristhianzl Cristhianzl added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit e2ff7b3 Jan 10, 2025
39 checks passed
@Cristhianzl Cristhianzl deleted the cz/new-input-list branch January 10, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants