Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: raise clearer error when aget_messages is missing in memory #6795

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

italojohnny
Copy link
Member

Add an explicit AttributeError when aget_messages is not found in the external memory object, helping users diagnose the issue.

Add an explicit AttributeError when `aget_messages` is not found in
the external memory object, helping users diagnose the issue.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 24, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 24, 2025
Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #6795 will degrade performances by 35.94%

Comparing chore/missing-aget_messages-check (c2a93fa) with main (8f276ad)

Summary

❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_flow_invalid_job_id 7.9 ms 12.3 ms -35.94%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant