-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump @rollup/plugin-commonjs from 26.0.1 to 28.0.1 #432
chore(deps-dev): bump @rollup/plugin-commonjs from 26.0.1 to 28.0.1 #432
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
This PR updates the @rollup/plugin-commonjs dependency from version 26.0.1 to 28.0.1, introducing potential changes to the build process and runtime behavior.
- Updated @rollup/plugin-commonjs in package.json from 26.0.1 to 28.0.1
- Breaking change: Switched to fdir for fewer dependencies in version 28.0.0
- Breaking change: Default strictRequires set to true in version 27.0.0
- Potential impact on build process and runtime behavior due to significant changes
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
8df1518
to
a027cff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
This PR updates the @rollup/plugin-commonjs dependency and includes version bumps across multiple packages in the langfuse-js monorepo. Here are the key changes:
- Updated versions from 3.27.0 to 3.27.1 in langfuse-core, langfuse-langchain, langfuse-node, langfuse-vercel, and langfuse packages
- Improved error handling in langfuse-vercel/src/LangfuseExporter.ts for cases with no root span
- Added new type exports from 'langfuse-core' in langfuse/src/langfuse.ts
- Updated lerna.json to reflect the new version 3.27.1
These changes appear to be part of a coordinated minor version update across the Langfuse ecosystem, likely including bug fixes and small improvements.
9 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
This PR updates the @rollup/plugin-commonjs dependency and includes minor version bumps across multiple packages in the langfuse-js monorepo.
- Updated @rollup/plugin-commonjs from 26.0.1 to 28.0.1 in root package.json
- Bumped versions from 3.27.1 to 3.27.2 in langfuse-core, langfuse-langchain, langfuse-node, langfuse-vercel, and langfuse packages
- Updated lerna.json to reflect the new version 3.27.2
- Breaking changes in @rollup/plugin-commonjs v27.0.0 and v28.0.0 may require attention, particularly the switch to fdir and default strictRequires setting
7 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
@@ -52,7 +52,7 @@ | |||
"@opentelemetry/sdk-node": "^0.53.0", | |||
"@opentelemetry/sdk-trace-node": "^1.25.1", | |||
"@rollup/plugin-babel": "^6.0.3", | |||
"@rollup/plugin-commonjs": "^26.0.1", | |||
"@rollup/plugin-commonjs": "^28.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: This update includes breaking changes. Ensure that the project is compatible with the new version, particularly regarding strictRequires and top-level 'this' usage.
"@rollup/plugin-commonjs": "^28.0.1", | |
// Review the breaking changes in the plugin documentation and update the code accordingly. | |
// Ensure compatibility with strictRequires and top-level 'this' usage. |
a027cff
to
c6b1f62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
This PR includes updates to @rollup/plugin-commonjs and introduces new data masking functionality in the Langfuse SDK, with version bumps across packages from 3.27.2 to 3.28.0.
- Added new masking functionality in
langfuse-core/src/index.ts
withmaskEventBodyInPlace
method for sensitive data protection - Introduced
MaskFunction
type inlangfuse-core/src/types.ts
for customizable data masking - Added comprehensive masking tests in
integration-test/langfuse-integration-fetch.spec.ts
covering traces, spans and generations - Version bumped to 3.28.0 across all packages to reflect the new masking feature
10 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
c6b1f62
to
f5f1fa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Based on the provided information, I'll summarize the latest changes since the previous review:
This PR updates packages from 3.28.0 to 3.29.0 and includes significant changes to prompt handling functionality.
- Added new
LangfusePromptRecord
type and enhancedPromptInput
type inlangfuse-core/src/types.ts
for improved prompt fallback support - Modified
BasePromptClient
inlangfuse-core/src/prompts/promptClients.ts
with required 'type' and 'prompt' properties - Added new test case in
integration-test/langfuse-integration-vercel.spec.ts
for tracing streamText calls with linked prompts - Breaking changes in @rollup/plugin-commonjs v28.0.1 include defaulting strictRequires to true and switching to fdir for dependencies
The changes focus on enhancing prompt handling capabilities while maintaining backward compatibility through derived classes.
13 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) from 26.0.1 to 28.0.1. - [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/commonjs-v28.0.1/packages/commonjs) --- updated-dependencies: - dependency-name: "@rollup/plugin-commonjs" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
f5f1fa6
to
f781fb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
This PR includes version bumps from 3.29.0 to 3.29.1 across all packages in the langfuse-js monorepo, coordinated with the @rollup/plugin-commonjs update.
- Version bumped to 3.29.1 in all package.json files (langfuse-core, langfuse-langchain, langfuse-node, langfuse-vercel, langfuse)
- Updated langfuse and langfuse-core dependencies to ^3.29.1 in dependent packages
- Breaking changes in @rollup/plugin-commonjs v28.0.1 affect build process only (strictRequires, fdir dependency)
8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Superseded by #487. |
Bumps @rollup/plugin-commonjs from 26.0.1 to 28.0.1.
Changelog
Sourced from
@rollup/plugin-commonjs
's changelog.Commits
0f45234
chore(release): commonjs v28.0.1dd1deee
chore(commonjs): upgrade picomatch (#1775)0af45c2
chore(release): commonjs v28.0.0c2a05eb
chore(commonjs): switch to fdir for fewer dependencies (#1741)b6fa3b1
chore(release): commonjs v27.0.08f02987
feat(commonjs)!: default strictRequires to true (#1639)274b72c
chore(repo): cherry-pick. commonjs. replace top-level this with exports name ...e2a7195
chore(release): commonjs v26.0.3e98927b
chore(commonjs): revert #16181e73857
chore(release): commonjs v26.0.2You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)