Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set env from user managed secrets/configmaps #21

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

keyurbhole
Copy link
Contributor

Summary:
This PR allows the user to have flexibility defining environment variables. via langfuse.additionalEnv. It ensures the env value can be assigned by any means for eg.

env:
  - name: LANGFUSE_LOG_LEVEL
    value: info
  - name: DATABASE_PASSWORD
    valueFrom:
      secretKeyRef:
        key: langfuse-database-password
        name: my-secrets
  - name: EMAIL_FROM_ADDRESS
    valueFrom:
      configMapKeyRef:
        key: email-from-addres
        name: my-configmap

I have also added examples/values-example.yaml file for reference.

I know there are open PR,

  1. Add Database ValueFrom #14 : It has used valueFrom, but only for env variables mentioned in values.yaml file and it does not address other variables mentioned in docs like S3 keys/secrets, smtp connection url, etc.
  2. feat: support nested maps in langfuse.additionalEnv #18 : It kind of solves but I think there is indentation issue

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Steffen911 Steffen911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Thank you very much for your contribution @keyurbhole.

@Steffen911 Steffen911 merged commit 13f1572 into langfuse:main Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants