[pt] Added words to added.txt and spelling.txt #10917
Conversation
WalkthroughThe pull request introduces new entries to both the part-of-speech and spelling dictionaries for the Portuguese language processing module. The changes include the addition of various words, proper nouns, and terms, formatted with their base forms and part-of-speech tags. These entries are marked for review, indicating they may require further validation. The updates enhance the dictionaries' coverage, potentially improving the language tool's performance in processing Portuguese text. Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt (1)
Line range hint
1-371: Consider reorganizing the dictionary for improved maintainability and functionality
The current structure of the file, which includes both foreign words and Portuguese words without clear separation, might impact the language tool's ability to accurately distinguish between languages. Consider:
a) Separating foreign words and Portuguese words into different sections or files.
b) Adding comments or metadata to categorize words (e.g., foreign, colloquial, proper nouns).The large number of additions might affect the performance of the language tool. It would be beneficial to:
a) Assess the impact of these additions on the tool's processing speed and memory usage.
b) Consider implementing a more efficient data structure for storing and accessing the dictionary.To improve maintainability and usability, consider:
a) Implementing a clear organizational structure (e.g., alphabetical order, word categories).
b) Adding version control comments or metadata to track when words were added or modified.
c) Developing guidelines for word inclusion to ensure consistency in future additions.These suggestions aim to enhance the long-term maintainability and effectiveness of the spelling dictionary. Implementing a more structured approach will make it easier to manage and update the dictionary in the future, especially as it continues to grow.
🧰 Tools
🪛 LanguageTool
[style] ~307-~307: Consider using the more polite verb “ask” (“tell” implies ordering/instructing someone).
Context: ...paul # Added by Marco A.G.Pinto. Pedro told me to add here until he fixes the dicti...(TELL_ASK)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt (1)
215-234: LGTM! New entries added correctly.The new entries have been added in the correct format, following the existing structure of the file. Each entry consists of three tab-separated fields: full form, base form, and part-of-speech tag, which is consistent with the file's requirements.
Consider rephrasing the comment on line 215 to use more neutral language:
- # Added by Marco A.G.Pinto. Pedro told me to add here until he fixes the dictionary building. + # Added by Marco A.G.Pinto. Pedro suggested adding entries here until the dictionary building process is fixed.This change maintains the same information while using more professional language.
🧰 Tools
🪛 LanguageTool
[style] ~215-~215: Consider using the more polite verb “ask” (“tell” implies ordering/instructing someone).
Context: ...0CN0 # Added by Marco A.G.Pinto. Pedro told me to add here until he fixes the dicti...(TELL_ASK)
[duplication] ~215-~215: Possible typo: you repeated a word
Context: ...until he fixes the dictionary building. autoinflingir autoinflingir VMN0000 Balikó Balikó NPMS000 Balikó Ba...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~216-~216: Possible typo: you repeated a word
Context: ...ng. autoinflingir autoinflingir VMN0000 Balikó Balikó NPMS000 Balikó Balikó NPMSS00 baratinho...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~217-~217: Possible typo: you repeated a word
Context: ...inflingir VMN0000 Balikó Balikó NPMS000 Balikó Balikó NPMSS00 baratinho baratinho NCMS000 bar...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~218-~218: Possible typo: you repeated a word
Context: ...kó Balikó NPMS000 Balikó Balikó NPMSS00 baratinho baratinho NCMS000 baratinhos baratinho NCMP000 ch...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~220-~220: Possible typo: you repeated a word
Context: ...ho NCMS000 baratinhos baratinho NCMP000 chinchada chinchada NCFS000 euromilhões euromilhões NCMN000...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~221-~221: Possible typo: you repeated a word
Context: ...nho NCMP000 chinchada chinchada NCFS000 euromilhões euromilhões NCMN000 inumada inumado AQ0FS0 inumadas...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~224-~224: Possible typo: you repeated a word
Context: ... inumado AQ0FS0 inumadas inumado AQ0FP0 inumado inumado AQ0MS0 inumados inumado AQ0MP0 Jumarie ...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~226-~226: Possible typo: you repeated a word
Context: ... inumado AQ0MS0 inumados inumado AQ0MP0 Jumarie Jumarie NPMS000 Milda Milda NPFS000 Nabeiro Nab...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~227-~227: Possible typo: you repeated a word
Context: ... inumado AQ0MP0 Jumarie Jumarie NPMS000 Milda Milda NPFS000 Nabeiro Nabeiro NPMS000 Nabeiro...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~228-~228: Possible typo: you repeated a word
Context: ...rie Jumarie NPMS000 Milda Milda NPFS000 Nabeiro Nabeiro NPMS000 Nabeiro Nabeiro NPMSS00 Rogeiro...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~229-~229: Possible typo: you repeated a word
Context: ...a Milda NPFS000 Nabeiro Nabeiro NPMS000 Nabeiro Nabeiro NPMSS00 Rogeiro Rogeiro NPMS000 Rogeiro...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~230-~230: Possible typo: you repeated a word
Context: ...Nabeiro NPMS000 Nabeiro Nabeiro NPMSS00 Rogeiro Rogeiro NPMS000 Rogeiro Rogeiro NPMSS00 Woodcoc...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~231-~231: Possible typo: you repeated a word
Context: ...Nabeiro NPMSS00 Rogeiro Rogeiro NPMS000 Rogeiro Rogeiro NPMSS00 Woodcock Woodcock NPMS000 Writi...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~232-~232: Possible typo: you repeated a word
Context: ...Rogeiro NPMS000 Rogeiro Rogeiro NPMSS00 Woodcock Woodcock NPMS000 WritingTool WritingTool NPMN000...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~233-~233: Possible typo: you repeated a word
Context: ...geiro NPMSS00 Woodcock Woodcock NPMS000 WritingTool WritingTool NPMN000(ENGLISH_WORD_REPEAT_RULE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt (1 hunks)
- languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt (1 hunks)
🧰 Additional context used
🪛 LanguageTool
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt
[style] ~215-~215: Consider using the more polite verb “ask” (“tell” implies ordering/instructing someone).
Context: ...0CN0 # Added by Marco A.G.Pinto. Pedro told me to add here until he fixes the dicti...(TELL_ASK)
[duplication] ~215-~215: Possible typo: you repeated a word
Context: ...until he fixes the dictionary building. autoinflingir autoinflingir VMN0000 Balikó Balikó NPMS000 Balikó Ba...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~216-~216: Possible typo: you repeated a word
Context: ...ng. autoinflingir autoinflingir VMN0000 Balikó Balikó NPMS000 Balikó Balikó NPMSS00 baratinho...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~217-~217: Possible typo: you repeated a word
Context: ...inflingir VMN0000 Balikó Balikó NPMS000 Balikó Balikó NPMSS00 baratinho baratinho NCMS000 bar...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~218-~218: Possible typo: you repeated a word
Context: ...kó Balikó NPMS000 Balikó Balikó NPMSS00 baratinho baratinho NCMS000 baratinhos baratinho NCMP000 ch...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~220-~220: Possible typo: you repeated a word
Context: ...ho NCMS000 baratinhos baratinho NCMP000 chinchada chinchada NCFS000 euromilhões euromilhões NCMN000...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~221-~221: Possible typo: you repeated a word
Context: ...nho NCMP000 chinchada chinchada NCFS000 euromilhões euromilhões NCMN000 inumada inumado AQ0FS0 inumadas...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~224-~224: Possible typo: you repeated a word
Context: ... inumado AQ0FS0 inumadas inumado AQ0FP0 inumado inumado AQ0MS0 inumados inumado AQ0MP0 Jumarie ...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~226-~226: Possible typo: you repeated a word
Context: ... inumado AQ0MS0 inumados inumado AQ0MP0 Jumarie Jumarie NPMS000 Milda Milda NPFS000 Nabeiro Nab...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~227-~227: Possible typo: you repeated a word
Context: ... inumado AQ0MP0 Jumarie Jumarie NPMS000 Milda Milda NPFS000 Nabeiro Nabeiro NPMS000 Nabeiro...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~228-~228: Possible typo: you repeated a word
Context: ...rie Jumarie NPMS000 Milda Milda NPFS000 Nabeiro Nabeiro NPMS000 Nabeiro Nabeiro NPMSS00 Rogeiro...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~229-~229: Possible typo: you repeated a word
Context: ...a Milda NPFS000 Nabeiro Nabeiro NPMS000 Nabeiro Nabeiro NPMSS00 Rogeiro Rogeiro NPMS000 Rogeiro...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~230-~230: Possible typo: you repeated a word
Context: ...Nabeiro NPMS000 Nabeiro Nabeiro NPMSS00 Rogeiro Rogeiro NPMS000 Rogeiro Rogeiro NPMSS00 Woodcoc...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~231-~231: Possible typo: you repeated a word
Context: ...Nabeiro NPMSS00 Rogeiro Rogeiro NPMS000 Rogeiro Rogeiro NPMSS00 Woodcock Woodcock NPMS000 Writi...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~232-~232: Possible typo: you repeated a word
Context: ...Rogeiro NPMS000 Rogeiro Rogeiro NPMSS00 Woodcock Woodcock NPMS000 WritingTool WritingTool NPMN000...(ENGLISH_WORD_REPEAT_RULE)
[duplication] ~233-~233: Possible typo: you repeated a word
Context: ...geiro NPMSS00 Woodcock Woodcock NPMS000 WritingTool WritingTool NPMN000(ENGLISH_WORD_REPEAT_RULE)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt
[style] ~307-~307: Consider using the more polite verb “ask” (“tell” implies ordering/instructing someone).
Context: ...paul # Added by Marco A.G.Pinto. Pedro told me to add here until he fixes the dicti...(TELL_ASK)
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt (1)
307-371: Review comment style and clarify the temporary nature of additions
The comment on line 307 provides useful context but uses informal language. Consider rephrasing it to maintain a more professional tone.
The temporary nature of these additions raises concerns about the long-term maintenance of the dictionary. It would be beneficial to:
a) Document the plan for integrating these words permanently.
b) Set a timeline for fixing the dictionary building process.The added words appear to be a mix of Portuguese terms, proper nouns, and their variations. While they seem appropriate for a spelling dictionary, it would be helpful to:
a) Verify that all added words are indeed correct Portuguese spellings.
b) Ensure consistency in including or excluding proper nouns, as some (e.g., "Balikó", "Jumarie") might not be common enough to warrant inclusion in a general spelling dictionary.Consider rephrasing the comment to something like:
- # Added by Marco A.G.Pinto. Pedro told me to add here until he fixes the dictionary building. + # Temporary additions by Marco A.G.Pinto, as requested by Pedro, pending improvements to the dictionary building process.To ensure the appropriateness of the added words, you may want to cross-reference them with authoritative Portuguese language resources or dictionaries.
🧰 Tools
🪛 LanguageTool
[style] ~307-~307: Consider using the more polite verb “ask” (“tell” implies ordering/instructing someone).
Context: ...paul # Added by Marco A.G.Pinto. Pedro told me to add here until he fixes the dicti...(TELL_ASK)
Heya, @susanaboatto and @p-goulart ,
I have added the words to added.txt and spelling.txt just like Pedro suggested.
This should keep me quiet for a few weeks regarding dictionary entries.
Summary by CodeRabbit
New Features
Bug Fixes