Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates footer design and adds additional links #55

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

jakebogan01
Copy link
Contributor

@xuelink I updated the footer design, as well as added the 3 new links. I tested it on 4 major browsers. Safari, Firefox, Chrome and Edge so far. If you see anything out of the ordinary let me know.

image

Copy link
Member

@xuelink xuelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakebogan01 it is actually better than i thought! but if you want to add another section, because we have more links :)

Open Source: under all github related links, (releases, goodfirstissue, contribute, changelog)

Company :

Apps : ios, android, webapp

Legal : its ok

If we will have place, we can also list our social links as well as duolingo did under Social tab.

for example here it has 4-5 columns in desktop and it may return 1 column in mobile responsively.

Screenshot 2024-04-17 at 12 59 42 AM

@xuelink
Copy link
Member

xuelink commented Apr 16, 2024

We may also add new section for Token seperately instead of listing under Company, because day by day we will increase these links about token.

Token

@xuelink
Copy link
Member

xuelink commented Apr 17, 2024

Another idea just poped up for SEO

  • Comparisons
    • vs HelloTalk
    • vs Tandem
    • vs Speaky

@jakebogan01
Copy link
Contributor Author

@xuelink Yeah I can try and add more links and see how it goes!

@jakebogan01
Copy link
Contributor Author

@xuelink I added more columns and links, let me know what you think. Not sure what you meant by the comparisons though

Copy link
Member

@xuelink xuelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldnt be better than it is! Thank you, im gonna fix some capital letter typo and merge it!

@xuelink xuelink self-requested a review April 17, 2024 16:18
@xuelink
Copy link
Member

xuelink commented Apr 17, 2024

Fixes #48

@xuelink xuelink merged commit 860917d into langx:main Apr 17, 2024
1 check passed
@jakebogan01
Copy link
Contributor Author

@xuelink No problem!

@jakebogan01 jakebogan01 deleted the issue-48-update-footer branch April 17, 2024 16:28
@xuelink xuelink linked an issue Apr 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 : Better Footer Design
2 participants