-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds infinite scroll and touch events and dot indicators #60
Conversation
updates variable type
Im now away from keyboard, gonna review it soon. By the way, can u please run this one as well if you didn't before $ npm run format |
Test failed $ npm run check |
@xuelink I ran npm run format, which runs prettier locally and it updated multiple files. Would you like me to commit those changes to this branch? |
@xuelink I ran npm run check and I'm not getting any errors now: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it works fine
@xuelink Thanks! |
Thank you for the helpful code, I also added touch events along with dots to indicate which slide is active