Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Winit window configuration, change default rendering colour #124

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

panekj
Copy link
Collaborator

@panekj panekj commented Oct 26, 2023

…parent

@panekj panekj changed the title extend winit window creation, re-export winit, make wgpu render trans… Extend Winit window configuration, change default rendering colour Oct 26, 2023
@panekj panekj marked this pull request as ready for review October 27, 2023 22:22
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #124 (3267438) into main (7fb3c9a) will decrease coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #124      +/-   ##
========================================
- Coverage   3.21%   3.19%   -0.03%     
========================================
  Files         54      54              
  Lines       9581    9642      +61     
========================================
  Hits         308     308              
- Misses      9273    9334      +61     
Files Coverage Δ
src/app.rs 0.00% <0.00%> (ø)
vger/src/lib.rs 0.00% <0.00%> (ø)
src/app_handle.rs 0.00% <0.00%> (ø)
src/window.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -442,7 +442,12 @@ impl Renderer for VgerRenderer {
view: &texture_view,
resolve_target: None,
ops: wgpu::Operations {
load: wgpu::LoadOp::Clear(wgpu::Color::WHITE),
load: wgpu::LoadOp::Clear(wgpu::Color {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe only do this if the window is transparent? also why a is 0.5 instead of 0.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there such configuration? The transparency setting is for winit to signal to OS that it might be transparent.

also why a is 0.5 instead of 0.0?

my own custom thing, will fix in a bit

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's what I meant, when the WindowConfig has transparent setting in it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how I'm supposed to do that, winit doesn't even expose the transparency state in Window, only in WindowBuilder

@dzhou121 dzhou121 merged commit 40e1700 into lapce:main Nov 1, 2023
8 of 9 checks passed
@panekj panekj deleted the feature/winit-ext branch November 1, 2023 09:46
jrmoulton pushed a commit to jrmoulton/floem that referenced this pull request Nov 6, 2023
…apce#124)

* extend winit window creation, re-export winit, make wgpu render transparent

* format code

* fix transparency to 0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants