Use the prop! macro for all style properties
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
========================================
- Coverage 3.20% 3.18% -0.02%
========================================
Files 54 54
Lines 9684 9764 +80
========================================
+ Hits 310 311 +1
- Misses 9374 9453 +79
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dzhou121
reviewed
Oct 31, 2023
| } | ||
| } | ||
| #[derive(Debug, Clone)] | ||
| pub struct Style { |
There was a problem hiding this comment.
I'm wondering if it's better to move StyleMap fields here. e.g.
pub struct Style {
pub(crate) map: HashMap<StylePropRef, StyleMapValue<Rc<dyn Any>>>,
pub(crate) selectors: HashMap<StyleSelector, StyleMap>,
}
There was a problem hiding this comment.
There's quite a bit of stuff that can be refactored with this PR. I feel like the PR is sufficiently large already though.
There was a problem hiding this comment.
Yeah we can merge this first and work on stuff in another PR.
|
don't know why this has conflicts after merging #127 |
|
GitHub's modifying the commits when you merge, so it didn't skip the commit for #127. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the builtin style field properties with properties defined by the
proc!macro. This makes them work with thehovermethod and animations (for some types).This is based on top of #127.