Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views module docs #620

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

jrmoulton
Copy link
Contributor

No description provided.

@jrmoulton
Copy link
Contributor Author

I'm experimenting with a few things here.

I've added a prelude and I think it is a really nice change. Whenever I create a new file I always have to do use module::* for several modules anyways so I figured it was about time to add a prelude.

I'm also experimenting with, in the views module, only doing pub use module::* for the most important views that are always used such as stacks, svg, container, text. I was already doing this for a few of the widgets that I had created such as dropdown and now I'm moving a few more to be like that. I feel like this is a good change. Leaving them in the modules makes the documentation for those items and the whole views module more consistent.

I'm considering not doing pub use module::* at all inside of the views module and instead selectively publicly exporting them from the prelude. This would really help to clean up the views module documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant