Fix text input crash #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #87 +/- ##
========================================
+ Coverage 4.09% 4.17% +0.08%
========================================
Files 43 43
Lines 7543 7561 +18
========================================
+ Hits 309 316 +7
- Misses 7234 7245 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash bug with text-input.
This was due to backspace not clearing the current selection.
I fixed the clearing of the selection on backspace. I also made so
replace_rangeis less likely to crash. It will log to stderr if the range was invalid, so we can still notice bugs like that.(Maybe we should add tracing in the future? Unsure.)