[1.x] Add nested controller route grouping (#433)

* Add nested controller route grouping * linting
laravel · Dec 17, 2024 · ac3b8e5 · ac3b8e5
1 parent 934b2a7
commit ac3b8e5
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/Support/RedisAdapter.php b/src/Support/RedisAdapter.php
@@ -50,7 +50,7 @@ public function xadd(string $key, array $dictionary): string|Pipeline|PhpRedis|R
      */
     public function xrange(string $key, string $start, string $end, ?int $count = null): array
     {
-        return collect($this->handle([ // @phpstan-ignore return.type, argument.templateType, argument.templateType
+        return collect($this->handle([ // @phpstan-ignore argument.templateType, argument.templateType
             'XRANGE',
             $this->config->get('database.redis.options.prefix').$key,
             $start,

diff --git a/tests/Feature/Recorders/SlowRequestsTest.php b/tests/Feature/Recorders/SlowRequestsTest.php
@@ -488,6 +488,30 @@
     Pulse::ignore(fn () => expect(DB::table('pulse_values')->count())->toBe(0));
 });
 
+it('handles controller nested route groups', function () {
+    Config::set('pulse.recorders.'.SlowRequests::class.'.threshold', 0);
+
+    Route::controller(MyController::class)->group(function () {
+        Route::get('index', 'index')->name('test')->withoutMiddleware('auth:admin');
+    })->withoutMiddleware('auth');
+
+    $response = get('/index');
+    Pulse::stopRecording();
+
+    $response->assertContent('ok');
+    $entries = DB::table('pulse_entries')->get();
+    expect($entries)->toHaveCount(1);
+    expect($entries[0]->key)->toBe(json_encode(['GET', '/index', 'MyController@index']));
+});
+
+class MyController
+{
+    public function index()
+    {
+        return 'ok';
+    }
+}
+
 class ExceptionThrowingRecorder
 {
     public function register(callable $record, Application $app): void