Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the App Name for Pulse dashboard header & browser title instead #384

Closed
wants to merge 1 commit into from

Conversation

ziming
Copy link

@ziming ziming commented May 29, 2024

Yesterday I made a PR adding a config('pulse.name') to allow the title of the Pulse Dashboard to be changed

#383

However Taylor closed it as Taylor prefer to just use config('app.name')

Not sure this needs it's own configuration option. We could just make the title read the app.name.

So this is a new PR doing that.

So it will look like this

CleanShot 2024-05-29 at 12 08 52@2x

And the browser tab title

CleanShot 2024-05-29 at 12 09 19@2x

I hope you will be open to this change making it to horizon & telescope too

@ziming ziming changed the title Use the App Name for Pulse dashboard header & browser title Use the App Name for Pulse dashboard header & browser title instead May 29, 2024
@taylorotwell
Copy link
Member

I dunno - I'm not sold.

@ziming
Copy link
Author

ziming commented May 30, 2024

okay. ur choice

@ziming ziming deleted the change-pulse-title-header-v2 branch May 30, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants