Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rebranding of Page Title and Logo #407

Closed
wants to merge 1 commit into from

Conversation

shealavington
Copy link

This PR adds some basic flexibility so anyone can take the pulse page and white-label it as part of their own application. This does not break features and adds extensibility.

I didn't write tests for this as there's such a thing as too many tests, and I worry this would be over-testing. If you would like a test for ensuring the slot data is overwritten, I'm happy to take a look?

I've enabled maintainer editability.

image

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants