Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing \ in dockerfile 8.3 #718

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: missing \ in dockerfile 8.3 #718

merged 1 commit into from
Sep 3, 2024

Conversation

saullo
Copy link
Contributor

@saullo saullo commented Sep 3, 2024

In commit #715 a change was made that removed the \ at the end of the command 'echo "extension=swoole.so" > /etc/php/8.3/cli/conf.d/20-swoole.ini'. It was added back because it was breaking the image build!

@pedrovian4
Copy link
Contributor

Oh my bad! Miss typing thanks for fixing it.

@Jubeki Jubeki mentioned this pull request Sep 3, 2024
@taylorotwell taylorotwell merged commit 0a7e289 into laravel:1.x Sep 3, 2024
5 checks passed
@Jubeki
Copy link
Contributor

Jubeki commented Sep 4, 2024

Hey @driesvints can you please create a patch release for this PR? Thanks!

Closes #719 and #720

@driesvints
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants