Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added vcpkg build guide in the readme #120

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Added vcpkg build guide in the readme #120

merged 3 commits into from
Sep 7, 2023

Conversation

aegroto
Copy link
Contributor

@aegroto aegroto commented Sep 4, 2023

Solves #119.

ldm0
ldm0 requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@ldm0 ldm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, overall it looks good! There are several feedbacks.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@aegroto
Copy link
Contributor Author

aegroto commented Sep 7, 2023

Thanks for your feedback, I have committed the required changes.

@ldm0 ldm0 merged commit ccec8b2 into larksuite:master Sep 7, 2023
16 checks passed
@ldm0
Copy link
Member

ldm0 commented Sep 7, 2023

Thanks for your work! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldm0 ldm0 ldm0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aegroto @ldm0