Feature/exceptions #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avion23
commented
Sep 18, 2022
avion23
force-pushed
the
feature/exceptions
branch
3 times, most recently
from
f6d6beb to
27427a5
Compare
|
Okay should be ready now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Laroche,
first, thank you for this software. German Taxes are insanity and you have a much better understanding than I.
I'm preparing a pull request with real changes. I'm trying to run my personal transaction reports (https://github.com/avion23/tastyworksTaxes/blob/main/test/merged3.csv) and I have some edge cases like reverse splits and stock mergers.
This Pull Request contains some "harmless" changes like in #22 . I've extracted this from the later pull requests so you can easier review them.