Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent double quoutes in description #56

Conversation

pablopunk
Copy link
Contributor

@pablopunk pablopunk commented Apr 28, 2020

fix #48

@pablopunk pablopunk requested a review from niftylettuce April 28, 2020 20:16
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #56 into master will increase coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   67.85%   68.23%   +0.37%     
==========================================
  Files           3        3              
  Lines          84       85       +1     
==========================================
+ Hits           57       58       +1     
  Misses         27       27              
Impacted Files Coverage Δ
sao.js 57.81% <100.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35489fe...43170ec. Read the comment docs.

@niftylettuce niftylettuce merged commit 5af446f into lassjs:master Apr 28, 2020
@niftylettuce
Copy link
Contributor

Released in v2.1.2, publishing to npm now

@pablopunk pablopunk deleted the throw-on-invalid-description-double-quotes branch April 28, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnhandledPromiseRejectionWarning
2 participants