Add mysql driver support for Sqlmetrics #14
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| ## Sqlmetrics Unit tests | ||
| ```bash | ||
| export LAST9_PQSQL_DSN="postgres://testuser:testpassword@localhost:5432/last9" | ||
| export LAST9_MYSQL_DSN="mysql:password@tcp(localhost:8306)/last9" | ||
| go test | ||
| ``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,15 @@ | ||
| package sqlmetrics | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "log" | ||
| "strings" | ||
|
|
||
| "github.com/blastrain/vitess-sqlparser/sqlparser" | ||
| pg_query "github.com/pganalyze/pg_query_go" | ||
| "github.com/tidwall/gjson" | ||
| ) | ||
|
|
||
| type LabelSet map[string]string | ||
|
|
||
| // Merge accepts a set of LabelSets and merge them into this LabelSet. | ||
|
|
@@ -22,7 +32,7 @@ func (l LabelSet) ToMap() map[string]string { | |
|
|
||
| // A type that user can extend to Parse a query and extract less verbose | ||
| // or more relevant labels out of it. | ||
| type LabelMaker func(string, string) LabelSet | ||
|
|
||
| const idealLabelLen = 20 | ||
|
|
||
|
|
@@ -31,12 +41,14 @@ const idealLabelLen = 20 | |
| // the metric server to its knees if left untapped. If this behaviour is not | ||
| // desired, a user can anwyay implement their own QToLabelSet and emit the | ||
| // raw query as-it-is. | ||
| func defaultLabelMaker(driver, q string) LabelSet { | ||
| statementName := getStatementName(driver, q) | ||
|
|
||
| if len(q) > idealLabelLen { | ||
| q = q[:idealLabelLen] + "..." | ||
| } | ||
|
|
||
| return LabelSet{"per": q, "statement": statementName} | ||
| } | ||
|
|
||
| // queryStatus is an enumeration. | ||
|
|
@@ -52,3 +64,48 @@ const ( | |
| func (q queryStatus) String() string { | ||
| return [...]string{"success", "failure"}[q] | ||
| } | ||
|
|
||
| // Accepts a driver name and query and returns the statement name of the first level query. | ||
| func getStatementName(driver, q string) string { | ||
|
|
||
| switch strings.Split(driver, ":")[0] { | ||
| case "postgres": | ||
|
There was a problem hiding this comment. Promote these strings as module global constants. Strings don't auto complete, variables do. |
||
| { | ||
| // Parse query and get query AST | ||
| tree, err := pg_query.ParseToJSON(q) | ||
| if err != nil { | ||
| log.Println("Error parsing query:", q, "Error occured :", err) | ||
| return "" | ||
| } | ||
|
|
||
| // Get the statement name of the first level query | ||
| statement := gjson.Get(tree[1:len(tree)-1], "[email protected]") | ||
|
|
||
| return statement.String() | ||
| } | ||
| case "mysql": | ||
| { | ||
| // Parse query and get query AST | ||
| stmt, err := sqlparser.Parse(q) | ||
| if err != nil { | ||
| log.Println("Error parsing query:", q, "Error :", err) | ||
| return "" | ||
| } | ||
|
|
||
| // convert AST to json string | ||
| stmtJson, err := json.Marshal(stmt) | ||
| if err != nil { | ||
| log.Println("Error in conversion to json :", q, "Error :", err) | ||
| return "" | ||
| } | ||
|
|
||
| // Parse the json and get the statement name of the first level query | ||
| if gjson.Get(string(stmtJson), "SelectExprs").String() != "" { | ||
| return "select" | ||
| } | ||
| return gjson.Get(string(stmtJson), "Action").String() | ||
| } | ||
| } | ||
|
|
||
| return "" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use dburl package to derive this. Every dsn that connects already has this information. If it doesn't. It may not connect eirher.