fix(agent.c): wait for agent to successfully spawn before exiting. #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force pushed to add the |
We open a pipe with the agent when we spawn it, and wait for them to say they're ready before exiting. This *should* fix lastpass#650. The underlying issue was that when doing: ``` lpass login [email protected] lpass show bar ``` in a script would cause a race condition where `lpass login` exited before the agent was successfully brought up. `lpass show bar` then tried to reach out to the agent, sees the socket isn't created yet, and says the user isn't logged in. Signed-Off-by: Arvinder Dhanoa <[email protected]>
|
@rui-rafael-lastpass Hi, apologies for the ping. I was wondering if / when this PR could potentially get reviewed? If possible I'd like to get this patch in for whenever your next release may be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We open a pipe with the agent when we spawn it, and wait for them to say they're ready before exiting. This should fix #650.
The underlying issue was that when doing:
in a script would cause a race condition where
lpass loginexited before the agent was successfully brought up.lpass show barthen tried to reach out to the agent, sees the socket isn't created yet, and says the user isn't logged in.