Apply coverity Fixes #318
Merged
Apply coverity Fixes #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simo Sorce <[email protected]>
Originally discovered by Coverity as an unused value and a NULL dereference, it was actually an unfinished error condition check. Fixes CID 469486: Code maintainability issues (UNUSED_VALUE) Fixes CID 469485: Null pointer dereferences (FORWARD_NULL) Signed-off-by: Simo Sorce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Jakuje these were introduced with your PR and caught by Coverity.
They seem pretty obvious fixes, bug given our CI is half broken now (all tests pass locally on my system using gnutls 3.8.1) just asking a token review before pushing through.