Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load profiles when they can't be available #333

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

simo5
Copy link
Member

@simo5 simo5 commented Jan 9, 2024

v2.40 (so anything below 3.0) spec did not have profiles.

Try to load them only for tokens that expose a 3+ version.

simo5 added 2 commits January 9, 2024 10:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes latchset#331

Signed-off-by: Simo Sorce <[email protected]>
Any version less than PKCS#11 3.0 does not have profile support,
so let's not even try to load them in that case.

Signed-off-by: Simo Sorce <[email protected]>
@simo5 simo5 requested a review from Jakuje January 9, 2024 16:56
Copy link
Contributor

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks simple enough that it should not need separate test.

@simo5 simo5 merged commit c9fb942 into latchset:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants